Fix weak_dispatch and explicit_conversion_dispatch in reference-returning overloads#13
Merged
mingxwa merged 2 commits intongcpp:mainfrom Mar 12, 2026
Merged
Conversation
tian-lt-personal
approved these changes
Mar 12, 2026
mingxwa
added a commit
that referenced
this pull request
Mar 13, 2026
…eturning overloads (#13) * Fix explicit_conversion_dispatch and weak_dispatch for reference-returning overloads * Resolve comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect behavior in
weak_dispatchandexplicit_conversion_dispatchwhen handling reference-returning overloads.Changes
operator T&andoperator T&&topro::details::converter, enabling implicit conversion to all valid reference types.concept explicitly_convertible, built onstd::reference_constructs_from_temporarysemantics. A conservative fallback is provided for pre-C++23 compilers, which may reject some valid user-defined reference conversions.pro::details::wildcardto reuseconverter.pro::explicit_conversion_dispatchto correctly support reference conversions.Resolves #11
Resolves #10